Support div_wrapping/rem_wrapping for numeric arithmetic kernels #7159
+48
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7158.
Rationale for this change
The
div/rem
operations may also overflow, so I want to adddiv_wrapping/rem_wrapping
operations to wrapping on overflow. Make it consistent with the logic ofadd/sub/mul
so that we can implementfail_on_overflow
feature fordiv/rem
in downstreamdatafusion
.What changes are included in this PR?
add
div_wrapping/rem_wrapping
functionsAre there any user-facing changes?
yes, newly added
div_wrapping/rem_wrapping
functions