reorder to avoid scaling cheap coders

apache · Feb 3, 2025 · ec36635 · ec36635
1 parent 0896bf5
commit ec36635
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
@@ -157,9 +157,10 @@ public boolean hasNext() {
     public T next() {
       T value = wrappedIterator.next();
       try {
-        if (sampleElement() || elementCoder.isRegisterByteSizeObserverCheap(value)) {
+        boolean cheap = elementCoder.isRegisterByteSizeObserverCheap(value);
+        if (cheap || sampleElement()) {
           observerProxy.setScalingFactor(
-              Math.max(samplingToken, SAMPLING_CUTOFF) / (double) SAMPLING_CUTOFF);
+              cheap ? 1.0 : Math.max(samplingToken, SAMPLING_CUTOFF) / (double) SAMPLING_CUTOFF);
           elementCoder.registerByteSizeObserver(value, observerProxy);
           if (observerProxy.getIsLazy()) {
             // The observer will only be notified of bytes as the result