Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btrie disable flag #33457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Btrie disable flag #33457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Metrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,13 @@ static class MetricsFlag {
private static final AtomicReference<@Nullable MetricsFlag> INSTANCE = new AtomicReference<>();
final boolean counterDisabled;
final boolean stringSetDisabled;
final boolean boundedTrieDisabled;

private MetricsFlag(boolean counterDisabled, boolean stringSetDisabled) {
private MetricsFlag(
boolean counterDisabled, boolean stringSetDisabled, boolean boundedTrieDisabled) {
this.counterDisabled = counterDisabled;
this.stringSetDisabled = stringSetDisabled;
this.boundedTrieDisabled = boundedTrieDisabled;
}

static boolean counterDisabled() {
Expand All @@ -80,6 +83,11 @@ static boolean stringSetDisabled() {
MetricsFlag flag = INSTANCE.get();
return flag != null && flag.stringSetDisabled;
}

static boolean boundedTrieDisabled() {
MetricsFlag flag = INSTANCE.get();
return flag != null && flag.boundedTrieDisabled;
}
}

/**
Expand All @@ -101,7 +109,13 @@ public static void setDefaultPipelineOptions(PipelineOptions options) {
if (stringSetDisabled) {
LOG.info("StringSet metrics are disabled");
}
MetricsFlag.INSTANCE.compareAndSet(null, new MetricsFlag(counterDisabled, stringSetDisabled));
boolean boundedTrieDisabled =
ExperimentalOptions.hasExperiment(exp, "disableBoundedTrieMetrics");
if (boundedTrieDisabled) {
LOG.info("BoundedTrie metrics are disabled");
}
MetricsFlag.INSTANCE.compareAndSet(
null, new MetricsFlag(counterDisabled, stringSetDisabled, boundedTrieDisabled));
}
}

Expand Down Expand Up @@ -287,6 +301,9 @@ public MetricName getName() {

@Override
public void add(Iterable<String> values) {
if (MetricsFlag.boundedTrieDisabled()) {
return;
}
MetricsContainer container = MetricsEnvironment.getCurrentContainer();
if (container != null) {
container.getBoundedTrie(name).add(values);
Expand Down
7 changes: 7 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ public void testMetricsFlag() {
Metrics.resetDefaultPipelineOptions();
assertFalse(Metrics.MetricsFlag.counterDisabled());
assertFalse(Metrics.MetricsFlag.stringSetDisabled());
assertFalse(Metrics.MetricsFlag.boundedTrieDisabled());
PipelineOptions options =
PipelineOptionsFactory.fromArgs("--experiments=disableCounterMetrics").create();
Metrics.setDefaultPipelineOptions(options);
Expand All @@ -274,6 +275,12 @@ public void testMetricsFlag() {
assertFalse(Metrics.MetricsFlag.counterDisabled());
assertTrue(Metrics.MetricsFlag.stringSetDisabled());
Metrics.resetDefaultPipelineOptions();
options = PipelineOptionsFactory.fromArgs("--experiments=disableBoundedTrieMetrics").create();
Metrics.setDefaultPipelineOptions(options);
assertFalse(Metrics.MetricsFlag.counterDisabled());
assertFalse(Metrics.MetricsFlag.stringSetDisabled());
assertTrue(Metrics.MetricsFlag.boundedTrieDisabled());
Metrics.resetDefaultPipelineOptions();
}
}

Expand Down
Loading