Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Restore memory sensitive GBK translation (#33520) #33521

Merged

Conversation

JozoVilcek
Copy link
Contributor

@JozoVilcek JozoVilcek commented Jan 7, 2025

Restore priority of memory sensitive GBK translation in spark-runner to avoid OOM #33520


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@JozoVilcek JozoVilcek changed the title [Spark] Restore memory sensitive GBK translation (#33520) [Spark] Restore memory sensitive GBK translation #33520 Jan 7, 2025
@JozoVilcek JozoVilcek changed the title [Spark] Restore memory sensitive GBK translation #33520 [Spark] Restore memory sensitive GBK translation (#33520) Jan 7, 2025
@je-ik je-ik self-requested a review January 7, 2025 13:05
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely should add some sort of test for the behavior, because otherwise we risk precisely the same situation - some future optimization will break this one. I'd also like to solve the conditions under which the optimization is correct, I'll be happy to assist with that. :)

@damccorm
Copy link
Contributor

waiting on author

Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! It makes sense to me. There are still two issues with the PR:
a) it effectively blocks the "groupByKeyInGlobalWindow" optimization
b) we are missing test that either of the optimizations is actually applied

More serious is the part a), because in the current implementation this PR actually creates a performance regression for cases when the GBK values actually fit into memory - first it uses the more expensive sort version and it also shuffles the (global) window along with the data.

I created list thread to discuss this further.

Copy link
Contributor

Reminder, please take a look at this pr: @damccorm

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@damccorm
Copy link
Contributor

waiting on author

@JozoVilcek
Copy link
Contributor Author

Run Java PreCommit

Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@je-ik je-ik merged commit 73d254b into apache:master Jan 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants