-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spark] Restore memory sensitive GBK translation (#33520) #33521
[Spark] Restore memory sensitive GBK translation (#33520) #33521
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should add some sort of test for the behavior, because otherwise we risk precisely the same situation - some future optimization will break this one. I'd also like to solve the conditions under which the optimization is correct, I'll be happy to assist with that. :)
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/TransformTranslator.java
Show resolved
Hide resolved
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/TransformTranslator.java
Show resolved
Hide resolved
waiting on author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! It makes sense to me. There are still two issues with the PR:
a) it effectively blocks the "groupByKeyInGlobalWindow" optimization
b) we are missing test that either of the optimizations is actually applied
More serious is the part a), because in the current implementation this PR actually creates a performance regression for cases when the GBK values actually fit into memory - first it uses the more expensive sort version and it also shuffles the (global) window along with the data.
I created list thread to discuss this further.
Reminder, please take a look at this pr: @damccorm |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm added as fallback since no labels match configuration Available commands:
|
waiting on author |
Run Java PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Restore priority of memory sensitive GBK translation in spark-runner to avoid OOM #33520
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.