Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java KafkaIO Performance test job #33685

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix Java KafkaIO Performance test job #33685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
922b0ee
fix java kafkaIO performance tests
akashorabek Jan 21, 2025
ed1520c
remove duplicated line
akashorabek Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/beam_PerformanceTests_Kafka_IO.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'schedule' && github.repository == 'apache/beam') ||
github.event.comment.body == 'Run Java KafkaIO Performance Test'
runs-on: [self-hosted, ubuntu-20.04, main]
runs-on: [self-hosted, ubuntu-20.04, highmem]
timeout-minutes: 120
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
strategy:
Expand Down
20 changes: 19 additions & 1 deletion sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.admin.NewPartitions;
import org.apache.kafka.clients.admin.NewTopic;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.serialization.ByteArrayDeserializer;
import org.apache.kafka.common.serialization.ByteArraySerializer;
Expand Down Expand Up @@ -142,6 +143,16 @@ public class KafkaIOIT {

private static final Logger LOG = LoggerFactory.getLogger(KafkaIOIT.class);

private static final int RETRIES_CONFIG = 10;

private static final int REQUEST_TIMEOUT_MS_CONFIG = 600000;

private static final int MAX_BLOCK_MS_CONFIG = 300000;

private static final int BUFFER_MEMORY_CONFIG = 100554432;

private static final int RETRY_BACKOFF_MS_CONFIG = 5000;

private static SyntheticSourceOptions sourceOptions;

private static Options options;
Expand Down Expand Up @@ -938,7 +949,14 @@ private KafkaIO.Write<byte[], byte[]> writeToKafka() {
return KafkaIO.<byte[], byte[]>write()
.withBootstrapServers(options.getKafkaBootstrapServerAddresses())
.withKeySerializer(ByteArraySerializer.class)
.withValueSerializer(ByteArraySerializer.class);
.withValueSerializer(ByteArraySerializer.class)
.withProducerConfigUpdates(
ImmutableMap.of(
ProducerConfig.RETRIES_CONFIG, RETRIES_CONFIG,
ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG, REQUEST_TIMEOUT_MS_CONFIG,
ProducerConfig.MAX_BLOCK_MS_CONFIG, MAX_BLOCK_MS_CONFIG,
ProducerConfig.BUFFER_MEMORY_CONFIG, BUFFER_MEMORY_CONFIG,
ProducerConfig.RETRY_BACKOFF_MS_CONFIG, RETRY_BACKOFF_MS_CONFIG));
}

private KafkaIO.Read<byte[], byte[]> readFromBoundedKafka() {
Expand Down
Loading