[Dataflow Streaming] Cache StateNamespace encoded keys using SoftReference #33689
+70
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
scwhittle
requested changes
Jan 22, 2025
| } | ||
|
|
||
| private String getStringKey() { | ||
| String stringKey = stringKeyRef.get(); |
There was a problem hiding this comment.
do you need some annotations to make this not show up as racy? we could have multiple threads calling this at the same time.
| @@ -219,6 +238,27 @@ public boolean equals(@Nullable Object obj) { | |||
| && Objects.equals(this.windowStructuralValue(), that.windowStructuralValue()); | |||
| } | |||
|
|
|||
| private String getStringKey() { | |||
There was a problem hiding this comment.
nit: just move this impl into stringKey()?
| private final Coder<W> windowCoder; | ||
| private final W window; | ||
| private final int triggerIndex; | ||
| private SoftReference<String> stringKeyRef; |
There was a problem hiding this comment.
as discussed, maybe we shouldn't use softrefs without some more investigation.
| sb.append(getStringKey()); | ||
| } | ||
|
|
||
| private String getStringKey() { |
There was a problem hiding this comment.
just inline in stringKey?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserWorker receives encodedKeys from backend, decodes it for processing and encodes it again for committing. This change caches the encoded keys using java SoftReferences and avoids encoding the keys again.