[Dataflow Streaming] Use concurrent queue for commit queue #33690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwhittle
requested changes
Jan 21, 2025
| @@ -23,7 +23,6 @@ | |||
| import java.util.Map; | |||
| import org.apache.beam.sdk.expansion.ExternalTransformRegistrar; | |||
| import org.apache.beam.sdk.io.aws2.common.ClientConfiguration; | |||
| import org.apache.beam.sdk.io.aws2.kinesis.KinesisIO; | |||
| Instant deadline = Instant.now().plus(timeout); | ||
| int spin = 0; | ||
| while (true) { | ||
| if (++spin > 1000) { |
There was a problem hiding this comment.
how much cpu does this burn if the queue is empty?
we could also look into other specialized queues like:
https://github.com/JCTools/JCTools/blob/master/jctools-core/src/main/java/org/jctools/queues/MpscBlockingConsumerArrayQueue.java
(random googling, would need some validation).
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| /** Queue bounded by a {@link WeightedSemaphore}. */ | ||
| public final class WeightedBoundedQueue<V> { | ||
| public final class WeightedBoundedQueue<V extends @NonNull Object> { |
There was a problem hiding this comment.
we might want to make this less generally named or at least comment on spinning so we know that before it gets used somewhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.