Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kafka client version to 3.7.0 #33960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,7 @@ class BeamModulePlugin implements Plugin<Project> {
def jsr305_version = "3.0.2"
def everit_json_version = "1.14.2"
def kafka_version = "2.4.1"
def kafka_client_version = "3.7.0"
def log4j2_version = "2.20.0"
def nemo_version = "0.1"
// [bomupgrader] determined by: io.grpc:grpc-netty, consistent with: google_cloud_platform_libraries_bom
Expand Down Expand Up @@ -830,7 +831,7 @@ class BeamModulePlugin implements Plugin<Project> {
jupiter_engine : "org.junit.jupiter:junit-jupiter-engine:$jupiter_version",
jupiter_params : "org.junit.jupiter:junit-jupiter-params:$jupiter_version",
kafka : "org.apache.kafka:kafka_2.11:$kafka_version",
kafka_clients : "org.apache.kafka:kafka-clients:$kafka_version",
kafka_clients : "org.apache.kafka:kafka-clients:$kafka_client_version",
log4j : "log4j:log4j:1.2.17",
log4j_over_slf4j : "org.slf4j:log4j-over-slf4j:$slf4j_version",
log4j2_api : "org.apache.logging.log4j:log4j-api:$log4j2_version",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
*/
package org.apache.beam.sdk.io.kafka;

import java.time.Duration;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import org.apache.beam.sdk.coders.CannotProvideCoderException;
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
Expand Down Expand Up @@ -236,7 +236,12 @@ public synchronized void commitSync(Map<TopicPartition, OffsetAndMetadata> offse
}

@Override
public synchronized void close(long timeout, TimeUnit unit) {
public void close() {
// Ignore closing since we're using a single consumer.
}

@Override
public synchronized void close(Duration timeout) {
// Ignore closing since we're using a single consumer.
}
}
Expand Down
Loading