[CALCITE-6764] Field access from a nullable ROW should be nullable #4127
+104
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
|
NobiGo
reviewed
Jan 9, 2025
| @@ -160,15 +155,7 @@ public int getFailureCount() { | |||
| ++failCount; | |||
| return litmus.fail(null); | |||
| } | |||
| final RelDataTypeField typeField = refType.getFieldList().get(index); | |||
There was a problem hiding this comment.
In the process of my use, the verification here is indeed effective. If only the nullability value is different, we can add 'RelOptUtil. eqIgnoreNullable'` to replace it?
There was a problem hiding this comment.
Ok, I will add this check back.
| @@ -65,6 +67,18 @@ public class RexFieldAccess extends RexNode { | |||
| this.expr = expr; | |||
There was a problem hiding this comment.
We can directly use this(expr, field, field.getType()); .
| CalciteConnection calciteConnection = connection.unwrap(CalciteConnection.class); | ||
| calciteConnection.getRootSchema().add("T", new RowTable()); | ||
| Statement statement = calciteConnection.createStatement(); | ||
| ResultSet resultSet = statement.executeQuery("SELECT P['a'].K FROM T"); |
There was a problem hiding this comment.
Do we need to verify the metadataResultSet#getMetaData is nullable? I'm not sure if this is possible.
There was a problem hiding this comment.
There is no nullability information as far as I know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.