Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAMEL-15588] Updated swagger-core to 1.6.2 #4311

Closed
wants to merge 3 commits into from
Closed

[CAMEL-15588] Updated swagger-core to 1.6.2 #4311

wants to merge 3 commits into from

Conversation

santam85
Copy link
Contributor

Updated swagger-core to 1.6.2
Updated swagger-parser to 1.0.51

This is to address a NoSuchMethod exception when upgrading to latest jackson. See swagger-api/swagger-core#3554 for details.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Please can you double check the swagger karaf feature in the repo Apache/camel-karaf? You'll need to fully build the camel repo and then run the build of camel-karaf. You can check the result under platform/karaf/features of the camel-karaf repository, by running an mvn verify or install. Thanks

@santam85
Copy link
Contributor Author

Lgtm. Please can you double check the swagger karaf feature in the repo Apache/camel-karaf? You'll need to fully build the camel repo and then run the build of camel-karaf. You can check the result under platform/karaf/features of the camel-karaf repository, by running an mvn verify or install. Thanks

Turns out I did have to update jackson-core in order to satisfy the updated swagger dependency requirements on Karaf.
There seems to be files generated during the full CI build that I can't seem to generate locally, is that expected?

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated file are part of the full build. If you rebase on master and run a build you should see them. This PR requires some attention on both side: plain camel and karaf

@oscerd
Copy link
Contributor

oscerd commented Sep 29, 2020

I'll have a look before merging, thanks.

@oscerd
Copy link
Contributor

oscerd commented Sep 29, 2020

I think you need to do git pull --rebase origin master, in this way your commit will be HEAD

@santam85
Copy link
Contributor Author

I think you need to do git pull --rebase origin master, in this way your commit will be HEAD

Sorry, I messed this up in my IDE

@oscerd
Copy link
Contributor

oscerd commented Sep 30, 2020

Merged on master. Thanks.

@oscerd oscerd closed this Sep 30, 2020
@santam85 santam85 deleted the feature/swagger-java-update branch September 30, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants