-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAMEL-15588] Updated swagger-core to 1.6.2 #4311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Please can you double check the swagger karaf feature in the repo Apache/camel-karaf? You'll need to fully build the camel repo and then run the build of camel-karaf. You can check the result under platform/karaf/features of the camel-karaf repository, by running an mvn verify or install. Thanks
Turns out I did have to update jackson-core in order to satisfy the updated swagger dependency requirements on Karaf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated file are part of the full build. If you rebase on master and run a build you should see them. This PR requires some attention on both side: plain camel and karaf
I'll have a look before merging, thanks. |
I think you need to do git pull --rebase origin master, in this way your commit will be HEAD |
Updated swagger-parser to 1.0.51
Sorry, I messed this up in my IDE |
Merged on master. Thanks. |
Updated swagger-core to 1.6.2
Updated swagger-parser to 1.0.51
This is to address a NoSuchMethod exception when upgrading to latest jackson. See swagger-api/swagger-core#3554 for details.