[skip ci] Set dismiss_stale_reviews: false in .asf.yaml
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `dismiss_stale_reviews: false` in `.asf.yaml` file to simplify the review process and reduce repetitive approvals. If this change introduces any issues or inefficiencies, we can restore the setting. Discussion: https://lists.apache.org/thread/56kwypo3o33zocyfwtb31oh0dp85r8zp
jiaqizho
approved these changes
Jan 20, 2025
|
How to handle significant code changes after resubmission? |
As commented in the mailing list1, the reviewers and committers need to go through the new changes to verify them again before merging the commits into the main branch. If they need to be updated again, the reviewers and committers can request changes again. Footnotes |
my-ship-it
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Set
dismiss_stale_reviews: falsein.asf.yamlfile to simplify the review process and reduce repetitive approvals. If this change introduces any issues or inefficiencies, we can restore the setting.Discussion: https://lists.apache.org/thread/56kwypo3o33zocyfwtb31oh0dp85r8zp
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context