Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect codes in pg_backup_archiver.c #899

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

reshke
Copy link
Contributor

@reshke reshke commented Feb 1, 2025

pg_backup_archiver.c: In function ‘CloneArchive’:
pg_backup_archiver.c:4877:9: error: the comparison will always evaluate as ‘true’ for the address of ‘binary_upgrade’ will never be NULL [-Werror=address]
 4877 |         ConnectDatabase((Archive *) clone, &clone->public.ropt->cparams, true, &clone->public.ropt->binary_upgrade);
      |         ^~~~~~~~~~~~~~~
In file included from pg_backup_archiver.h:30,
                 from parallel.h:19,
                 from pg_backup_archiver.c:39:
pg_backup.h:138:33: note: ‘binary_upgrade’ declared here
  138 |         int                     binary_upgrade;
      |                                 ^~~~~~~~~~~~~~

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


pg_backup_archiver.c: In function ‘CloneArchive’:
pg_backup_archiver.c:4877:9: error: the comparison will always evaluate as ‘true’ for the address of ‘binary_upgrade’ will never be NULL [-Werror=address]
 4877 |         ConnectDatabase((Archive *) clone, &clone->public.ropt->cparams, true, &clone->public.ropt->binary_upgrade);
      |         ^~~~~~~~~~~~~~~
In file included from pg_backup_archiver.h:30,
                 from parallel.h:19,
                 from pg_backup_archiver.c:39:
pg_backup.h:138:33: note: ‘binary_upgrade’ declared here
  138 |         int                     binary_upgrade;
      |                                 ^~~~~~~~~~~~~~
@reshke reshke merged commit 4b71649 into apache:main Feb 3, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants