Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of GPSHPositioningError in GpsTagConstants #451

Merged

Conversation

Stefal
Copy link
Contributor

@Stefal Stefal commented Oct 17, 2024

Hi!

I'm not a Java developer at all. I've done my best to understand the code and add the support of the GPSHPositioningError tag. This tag seems available since Exif 2.3

GPSHPositioningError
This tag indicates horizontal positioning errors in meters.
Tag = 31 (1F.H)
Type = RATIONAL
Count = 1
Default = None

Note When the tag Type is ASCII, it shall be terminated with NULL.
It shall be noted carefully that since the value count includes the terminator NULL, the total
count is the number of data+1. For example, GPSLatitudeRef cannot have any values other
than Type ASCII 'N' or 'S'; but because the terminator NULL is added, the value of N is 2.

@garydgregory
Copy link
Member

Hello @Stefal

Thank you for your PR.

New public and protected elements should have a Javadoc comment that includes a since tag.

This PR needs a unit test to prove the change does what you think it does.

It's OK to include an image with the test as long as it is yours, or if not, its license is Apache 2.0 or compatible with the Apache license.

@Stefal
Copy link
Contributor Author

Stefal commented Oct 17, 2024

I didn't add a Javadoc because there isn't one in the file, nor a test.

I wrote the test with the help of WebPMetadataTest.java and MetadataExample.java. I hope it's not too bad.

edit: BTW, which latest Exif release is supported ? 2.31 ?

@garydgregory
Copy link
Member

Hello @Stefal

Thank you for your updates.

Please run mvn before you push to run and fix all build checks.

I'm not sure which exact version of Exif we support but that would be good to document.

@Stefal
Copy link
Contributor Author

Stefal commented Oct 19, 2024

Hello @garydgregory

I've fixed the 2 CheckStyle errors Maven reported.

@Stefal
Copy link
Contributor Author

Stefal commented Oct 26, 2024

Is there anything more I need to do to get this pull request merged?

I'm not sure which exact version of Exif we support but that would be good to document.

if #49 was merged we could say it's v2.32 😄

@garydgregory
Copy link
Member

@Stefal
I'll review later today or tomorrow.
Ty!

@garydgregory garydgregory merged commit 259bf01 into apache:master Oct 26, 2024
17 checks passed
@garydgregory garydgregory changed the title Add support of GPSHPositioningError Add support of GPSHPositioningError in GpsTagConstants Oct 26, 2024
@Stefal
Copy link
Contributor Author

Stefal commented Oct 26, 2024

Thank you @garydgregory
It will help me for improving jpeg metadata support in Josm and then in the panoramax project.

@garydgregory
Copy link
Member

@Stefal
Yw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants