-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of GPSHPositioningError in GpsTagConstants #451
Add support of GPSHPositioningError in GpsTagConstants #451
Conversation
Hello @Stefal Thank you for your PR. New public and protected elements should have a Javadoc comment that includes a since tag. This PR needs a unit test to prove the change does what you think it does. It's OK to include an image with the test as long as it is yours, or if not, its license is Apache 2.0 or compatible with the Apache license. |
I didn't add a Javadoc because there isn't one in the file, nor a test. I wrote the test with the help of edit: BTW, which latest Exif release is supported ? 2.31 ? |
Hello @Stefal Thank you for your updates. Please run I'm not sure which exact version of Exif we support but that would be good to document. |
Hello @garydgregory I've fixed the 2 CheckStyle errors Maven reported. |
Is there anything more I need to do to get this pull request merged?
if #49 was merged we could say it's v2.32 😄 |
@Stefal |
Thank you @garydgregory |
@Stefal |
Hi!
I'm not a Java developer at all. I've done my best to understand the code and add the support of the GPSHPositioningError tag. This tag seems available since Exif 2.3