Skip to content

Commit

Permalink
Fix layout of the "Solve Conflicts" modal (#1470)
Browse files Browse the repository at this point in the history
* Fix: misaligned buttons in the doc conflicts confirmation modal

* Fix: npm audit failures

* Fix: bump Node used in CI to 20 to address failure with latest 'npm'
  • Loading branch information
Antonio-Maranhao authored Jan 20, 2025
1 parent 87a7377 commit 44d0683
Show file tree
Hide file tree
Showing 5 changed files with 76 additions and 76 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- name: Install npm packages
run: |
npm install -g npm@latest
Expand All @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
- run: ./bin/build-couchdb-dev.sh
env:
Expand Down
9 changes: 7 additions & 2 deletions app/addons/documents/assets/scss/revision-browser.scss
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ div#dashboard-content div.revision-wrapper {
}

.delete-conflicts-modal {
.do-not-show-again label {
font-size: 13px;
.do-not-show-again {
&.form-check {
padding-left: 2em;
}
label {
font-size: 13px;
}
}
}
31 changes: 12 additions & 19 deletions app/addons/documents/rev-browser/components/confirmmodal.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,31 +54,24 @@ export default class ConfirmModal extends React.Component {
</p>
</Modal.Body>
<Modal.Footer>

<div className='col-12'>
<Form.Check type="checkbox"
className='do-not-show-again'
label="Do not show this warning message again"
onChange={() => { this.setState({checked: !this.state.checked }); }} />
</div>

<div className="col-auto">
<Button href="#"
variant="cf-cancel"
className='cancel-link'
onClick={this.close}
data-bypass="true"
>
Cancel
</Button>
</div>
<div className="col-auto">
<ConfirmButton
onClick={this.onDeleteConflicts}
text="Delete Revisions"
variant="danger" />
</div>

<Button href="#"
variant="cf-cancel"
className='cancel-link'
onClick={this.close}
data-bypass="true"
>
Cancel
</Button>
<ConfirmButton
onClick={this.onDeleteConflicts}
text="Delete Revisions"
variant="danger" />
</Modal.Footer>
</Modal>
);
Expand Down
106 changes: 54 additions & 52 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"fauxton": "./bin/fauxton"
},
"engines": {
"node": "^18"
"node": "^20"
},
"devDependencies": {
"@babel/cli": "^7.18.10",
Expand Down

0 comments on commit 44d0683

Please sign in to comment.