Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process status to tasks #1463

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add process status to tasks #1463

merged 1 commit into from
Oct 23, 2024

Conversation

noahmehl
Copy link
Contributor

@noahmehl noahmehl commented Oct 2, 2024

Overview

As a user, it would be convenient to see the process_status value for a compaction job. This is because smoosh may start a compaction job and have some progress before suspending it because it's outside the window for processing.

Testing recommendations

GitHub issue number

This is to address this issue: apache/couchdb#3816

Related Pull Requests

N/A

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

@noahmehl noahmehl force-pushed the main branch 2 times, most recently from e424095 to b5aa52b Compare October 8, 2024 17:48
Copy link

@espy espy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thanks for your contribution! @janl and I tested this change with view and db compactions, replications and indexing, and I observed it appearing with compactions and indexing. The effect is that it occasionally appends progress status: running or progress status: runnable to the end of the status table cells. Most of the time, no message is visible, presumably because it’s waiting and the code omits that. I could not observe any other status types. Some screenshots for reference:

Bildschirmfoto 2024-10-23 um 13 44 33

Bildschirmfoto 2024-10-23 um 13 34 01

👍 from us!

@Antonio-Maranhao
Copy link
Contributor

Thanks @noahmehl for the PR, and Jan and Alex for testing it out. Tests passed so I'm merging it.

@Antonio-Maranhao Antonio-Maranhao merged commit 87a7377 into apache:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants