RAT-98: Added FSInfo to handle file system differences #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudenw
force-pushed
the
Create_FSInfo
branch
from
717508c to
c6397a0
Compare
ottlinger
changed the title
Claudenw
force-pushed
the
Create_FSInfo
branch
from
acae2df to
103d9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a a part of #417 and is here to simplify the review.
The FSInfo allows us to easily test multiple file systems without having to create actual file systems. It extracts away the file system info that we need for document name checks and add Google JimFS for testing.
Other changes include change DocumentName.baseName to a DocumentName rather than a string. This adds some complexity to the builder but makes other checks much easier.