Add timeout and keep-alive settings for Grpc Client and Server #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please help to take a look and review. |
mingmwang
changed the title
andygrove
reviewed
Aug 5, 2022
Comment on lines
+324
to
+332
| let endpoint = tonic::transport::Endpoint::new(dst)? | ||
| .connect_timeout(Duration::from_secs(20)) | ||
| .timeout(Duration::from_secs(20)) | ||
| // Disable Nagle's Algorithm since we don't want packets to wait | ||
| .tcp_nodelay(true) | ||
| .tcp_keepalive(Option::Some(Duration::from_secs(3600))) | ||
| .http2_keep_alive_interval(Duration::from_secs(300)) | ||
| .keep_alive_timeout(Duration::from_secs(20)) | ||
| .keep_alive_while_idle(true); |
There was a problem hiding this comment.
It would be nice to make these options user-configurable via the recently added config mechanism that was added in DataFusion (but not integrated with Ballista yet).
There was a problem hiding this comment.
I filed #117 for this and I plan on picking this up
andygrove
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Looks reasonable to me but I have not been working with gRPC lately. Maybe @avantgardnerio could review as well since he is working on Flight SQL support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #114.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?