Check for expected benchmark results in integration test #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
I cannot fully implement this until apache/datafusion#3478 is fixed |
andygrove
changed the title
Dandandan
approved these changes
Oct 28, 2022
Agreed. It would also be nice if I didn't have to keep making the same changes in both repos 🙄 but I don't have a good plan for how to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #330
Rationale for this change
The integration test has little value if it does not check that query results are correct.
This is implemented now but disabled for most queries because we do not produce the correct results because of issues with decimal precision and also because the test relies on casting the expected results (in csv format) to decimal and we do not support casting utf8 to decimal yet.
What changes are included in this PR?
check query results
Are there any user-facing changes?
No