fix: remove use of deprecated make_scalar_function
#906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make_scalar_function` has been deprecated since v36 [0]. It is being removed from the public api in v43 [1]. [0]: apache/datafusion#8878 [1]: apache/datafusion#12505
timsaucer
requested changes
Oct 12, 2024
timsaucer
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
make_scalar_functionhas been deprecated since v36. It is being removed from the public api in v43.What changes are included in this PR?
datafusionalready provides utilities for convertingColumnarValueto and fromArrayRef, so I simply used those to convert the input and output into whatScalarUDFrequires.Are there any user-facing changes?
No.
Additional Context
It may be useful to review how upstream previously converted functions that use ArrayRef to ScalarUDF.
https://github.com/apache/datafusion/blob/8e8bb89a285c6fe6e8186378b7798d3d213f08f7/datafusion/physical-expr/src/functions.rs#L79-L122