-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support struct_expr generate struct in sql #2389
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ebaa85f
Support struct_expr generate struct in sql
Ted-Jiang 5e1abbc
fix comment
Ted-Jiang b11f2ef
remove useless code
Ted-Jiang 5b675a0
fix fmt
Ted-Jiang f94ecee
Update datafusion/physical-expr/src/struct_expressions.rs
Ted-Jiang 7c4e878
fix
Ted-Jiang b26c388
Merge remote-tracking branch 'origin/support_struct' into support_struct
Ted-Jiang 6ac645c
use error instead of panic
Ted-Jiang 9fb17a5
fix ut
Ted-Jiang 73a8901
fix
Ted-Jiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use arrow::datatypes::DataType; | ||
|
||
/// Currently supported types by the struct function. | ||
pub static SUPPORTED_STRUCT_TYPES: &[DataType] = &[ | ||
DataType::Boolean, | ||
DataType::UInt8, | ||
DataType::UInt16, | ||
DataType::UInt32, | ||
DataType::UInt64, | ||
DataType::Int8, | ||
DataType::Int16, | ||
DataType::Int32, | ||
DataType::Int64, | ||
DataType::Float32, | ||
DataType::Float64, | ||
DataType::Utf8, | ||
DataType::LargeUtf8, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
//! Struct expressions | ||
|
||
use arrow::array::*; | ||
use arrow::datatypes::{DataType, Field}; | ||
use datafusion_common::{DataFusionError, Result}; | ||
use datafusion_expr::ColumnarValue; | ||
use std::sync::Arc; | ||
|
||
fn array_struct(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
// do not accept 0 arguments. | ||
if args.is_empty() { | ||
return Err(DataFusionError::Internal( | ||
"struct requires at least one argument".to_string(), | ||
)); | ||
} | ||
|
||
let vec: Vec<_> = args | ||
.iter() | ||
.enumerate() | ||
.map(|(i, arg)| -> (Field, ArrayRef) { | ||
let field_name = format!("c{}", i); | ||
match arg.data_type() { | ||
DataType::Utf8 | ||
| DataType::LargeUtf8 | ||
| DataType::Boolean | ||
| DataType::Float32 | ||
| DataType::Float64 | ||
| DataType::Int8 | ||
| DataType::Int16 | ||
| DataType::Int32 | ||
| DataType::Int64 | ||
| DataType::UInt8 | ||
| DataType::UInt16 | ||
| DataType::UInt32 | ||
| DataType::UInt64 => ( | ||
Field::new(field_name.as_str(), arg.data_type().clone(), true), | ||
arg.clone(), | ||
), | ||
data_type => unimplemented!("struct not support {} type", data_type), | ||
} | ||
}) | ||
.collect(); | ||
|
||
Ok(Arc::new(StructArray::from(vec))) | ||
} | ||
|
||
/// put values in a struct array. | ||
pub fn struct_expr(values: &[ColumnarValue]) -> Result<ColumnarValue> { | ||
let arrays: Vec<ArrayRef> = values | ||
.iter() | ||
.map(|x| match x { | ||
ColumnarValue::Array(array) => array.clone(), | ||
ColumnarValue::Scalar(scalar) => scalar.to_array().clone(), | ||
}) | ||
.collect(); | ||
Ok(ColumnarValue::Array(array_struct(arrays.as_slice())?)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should return an
Err
rather than panic here