Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove the bench most likely to cause OOM in CI #9858

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Mar 29, 2024

Which issue does this PR close?

Addresses issue found in #9800 (comment).

Closes #9856

Part of #5504

Rationale for this change

TPC-H 10 in-mem is probably to large to handle inside shared runners.

What changes are included in this PR?

Remove the recently added tpch_mem10 bench.

Are these changes tested?

Are there any user-facing changes?

Only for devs (should see TPC-H 1, 1-mem and 10 benches now only).

@gruuya gruuya changed the title Remove the two cases most likely to cause OOM in CI Minor: Remove the two cases most likely to cause OOM in CI Mar 29, 2024
@gruuya gruuya changed the title Minor: Remove the two cases most likely to cause OOM in CI Minor: Remove the bench most likely to cause OOM in CI Mar 29, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gruuya -- makes sense to me

@alamb alamb merged commit f1adc68 into apache:main Mar 29, 2024
26 checks passed
@gruuya gruuya deleted the remove-pr-bench-mem branch March 29, 2024 13:50
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants