Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc](backup)Modify backup and restore documentation #1906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caoliang-web
Copy link
Contributor

@caoliang-web caoliang-web commented Jan 22, 2025

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 参数需要加粗和序号

...
)
PROPERTIES ("key"="value", ...);
BACKUP SNAPSHOT <db_name>.{<snapshot_name>}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个花括号,应该是方括号?

Suggested change
BACKUP SNAPSHOT <db_name>.{<snapshot_name>}
BACKUP SNAPSHOT <db_name>[.<snapshot_name>]

PROPERTIES ("key"="value", ...);
BACKUP SNAPSHOT <db_name>.{<snapshot_name>}
TO `<repository_name>`
[ON|EXCLUDE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个方括号,应该是花括号?然后 ON 后面都是可选的?所以在 ON 前面应该有个方括号?

Suggested change
[ON|EXCLUDE]
[ { ON | EXCLUDE }

illustrate:
## Required Parameters

`<db_name>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要加粗
  2. 需要序号
Suggested change
`<db_name>`
** 1. `<db_name>`**

( <table_name> [ PARTITION ( <partition_name> [, ...] ) ]
[, ...] ) ]

[PROPERTIES ("key" = "value" [,...])];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[PROPERTIES ("key" = "value" [,...])];
[ PROPERTIES ( "<key>" = "<value>" [ , ... ] )]];


The name of the partition to be backed up. If not specified, all partitions of the corresponding table will be backed up.

`<PROPERTIES>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`<PROPERTIES>`
`[ PROPERTIES ( "<key>" = "<value>" [ , ... ] ) ]`


```sql
RESTORE SNAPSHOT [db_name].{snapshot_name}
FROM `repository_name`
RESTORE SNAPSHOT [<db_name>].{<snapshot_name>}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来和 backup 语法类似的问题

illustrate:
## Parameters

`<db_name>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数列表存在和 backup 类似的问题

2. brief: only show key information of RESTORE tasks, columns RestoreObjs, Progress, TaskErrMsg will not show


## Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要介绍 [BRIEF]

2. brief: only show key information of RESTORE tasks, columns RestoreObjs, Progress, TaskErrMsg will not show


## Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意,语法章节,需要区分必选参数(Required Parameters)和可选参数(Optional Parameters),分成两个小节

SHOW SNAPSHOT ON example_repo
WHERE SNAPSHOT = "backup1" AND TIMESTAMP = "2018-05-05-15-34-26";
```
| Column | Note |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Column | Note |
| Column | Description |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants