[fix](func) Fix precision loss in ST_GeometryFromWKB coordinate parsing #46661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32784 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 195086 ms |
ClickBench: Total hot run time: 31.63 s |
|
run buildall |
TPC-H: Total hot run time: 32508 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 195277 ms |
ClickBench: Total hot run time: 31.44 s |
HappenLee
reviewed
Jan 15, 2025
be/src/geo/geo_types.cpp
Outdated
| double value = S2LatLng::Longitude(*_point).degrees(); | ||
| // Handle values very close to integers | ||
| double rounded = round(value); | ||
| if (std::abs(value - rounded) < 1e-13) { // 使用更大的阈值 |
There was a problem hiding this comment.
please use english, thank you
felixwluo
force-pushed
the
fix-st-0108
branch
from
b3e6a7f to
c274a05
Compare
|
I will review this PR later |
|
run buildall |
TPC-H: Total hot run time: 31963 ms |
TPC-DS: Total hot run time: 188143 ms |
felixwluo
force-pushed
the
fix-st-0108
branch
from
fa12fe9 to
d130192
Compare
|
run buildall |
TPC-H: Total hot run time: 32231 ms |
TPC-DS: Total hot run time: 187136 ms |
ClickBench: Total hot run time: 30.36 s |
|
TeamCity be ut coverage result: |
felixwluo
force-pushed
the
fix-st-0108
branch
from
79544da to
a9848ee
Compare
|
run buildall |
TPC-H: Total hot run time: 32236 ms |
TPC-DS: Total hot run time: 188594 ms |
ClickBench: Total hot run time: 31.61 s |
ClickBench: Total hot run time: 30.78 s |
|
run cloud_p0 |
zclllyybb
reviewed
Jan 20, 2025
be/src/geo/wkb_parse.cpp
Outdated
| uint32_t typeInt = ctx->dis.readUnsigned(); | ||
|
|
||
| // Check if geometry has SRID | ||
| bool has_srid = (typeInt & 0x20000000) != 0; |
There was a problem hiding this comment.
for magic numbers, we should define it as constexpr variable with comment giving its source and explaining what does it do
felixwluo
force-pushed
the
fix-st-0108
branch
from
11820a5 to
ea72e50
Compare
|
run buildall |
felixwluo
force-pushed
the
fix-st-0108
branch
from
a911114 to
8973a68
Compare
|
run buildall |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32182 ms |
TPC-DS: Total hot run time: 193752 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.76 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…ng (#46661) ### What problem does this PR solve? Issue Number: close #46619 Root Cause: ``` 1. Unnecessary floating-point number conversions in coordinate handling: 1.1 converting double to string using absl::StrFormat 1.2 converting string back to double using std::stod each conversion caused precision loss. 2. Byte order handling issue in WKB parsing: 2.1 using machine endian before properly reading WKB byte order flag 2.2 this caused incorrect interpretation of coordinate values ``` Solution: ``` 1. Remove unnecessary coordinate value conversions: 1.1 directly use S2LatLng's degrees() value without string formatting 1.2 increase output precision in print_s2point to 15 digits 2. Fix WKB byte order handling: 2.1 read byte order flag first 2.2 set correct byte order before parsing coordinates ``` Result: before: ``` POINT (1.461652102e-231 3.34424828009e-59) ``` after: ``` POINT(117.194767000297 36.46326301008) ```
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…ng (#46661) ### What problem does this PR solve? Issue Number: close #46619 Root Cause: ``` 1. Unnecessary floating-point number conversions in coordinate handling: 1.1 converting double to string using absl::StrFormat 1.2 converting string back to double using std::stod each conversion caused precision loss. 2. Byte order handling issue in WKB parsing: 2.1 using machine endian before properly reading WKB byte order flag 2.2 this caused incorrect interpretation of coordinate values ``` Solution: ``` 1. Remove unnecessary coordinate value conversions: 1.1 directly use S2LatLng's degrees() value without string formatting 1.2 increase output precision in print_s2point to 15 digits 2. Fix WKB byte order handling: 2.1 read byte order flag first 2.2 set correct byte order before parsing coordinates ``` Result: before: ``` POINT (1.461652102e-231 3.34424828009e-59) ``` after: ``` POINT(117.194767000297 36.46326301008) ```
yiguolei
pushed a commit
that referenced
this pull request
Jan 24, 2025
…dinate parsing #46661 (#47263) Cherry-picked from #46661 Co-authored-by: lw112 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #46619
Root Cause:
Solution:
Result:
before:
after:
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)