Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34572] Support OceanBase Jdbc Catalog #109

Merged
merged 3 commits into from
Aug 2, 2024
Merged

[FLINK-34572] Support OceanBase Jdbc Catalog #109

merged 3 commits into from
Aug 2, 2024

Conversation

whhe
Copy link
Member

@whhe whhe commented Mar 26, 2024

No description provided.

@whhe whhe force-pushed the oceanbase-catalog branch from 1a5a834 to ca1fc4c Compare March 26, 2024 12:15
@whhe
Copy link
Member Author

whhe commented Mar 26, 2024

Would you please take a look on this? @leonardBang

@whhe whhe force-pushed the oceanbase-catalog branch from ca1fc4c to 4910089 Compare March 30, 2024 03:04
@whhe
Copy link
Member Author

whhe commented Mar 30, 2024

@MartijnVisser PTAL

@whhe whhe force-pushed the oceanbase-catalog branch 3 times, most recently from 6b8c734 to 12a77ba Compare May 15, 2024 09:46
@whhe
Copy link
Member Author

whhe commented May 15, 2024

@eskabetxe PTAL

eskabetxe
eskabetxe reviewed May 18, 2024
View reviewed changes
Copy link
Member

@eskabetxe eskabetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments

.../main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseCatalog.java Outdated Show resolved Hide resolved
...rg/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseOracleCatalogITCase.java Outdated Show resolved Hide resolved
.../main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseCatalog.java Outdated Show resolved Hide resolved
@whhe
Copy link
Member Author

whhe commented May 19, 2024

I left some minor comments

Hi @eskabetxe, I updated these files, please take a look again.

@whhe
Copy link
Member Author

whhe commented Jun 3, 2024

@eskabetxe PTAL

@whhe
Copy link
Member Author

whhe commented Jun 17, 2024

Anyone available? @eskabetxe @GOODBOY008 @leonardBang

@whhe whhe force-pushed the oceanbase-catalog branch 3 times, most recently from 132291c to b8dca26 Compare June 28, 2024 10:35
RocMarshal
RocMarshal reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @whhe Thx for the contribution.
Would you mind fixing the failed CI action before the next review ?

@whhe whhe force-pushed the oceanbase-catalog branch 9 times, most recently from 3cd69a4 to 3c15974 Compare July 3, 2024 10:59
@whhe
Copy link
Member Author

whhe commented Jul 3, 2024

Hi, @whhe Thx for the contribution. Would you mind fixing the failed CI action before the next review ?

Hi @RocMarshal, the CI failure is fixed now. PTAL

@whhe whhe force-pushed the oceanbase-catalog branch 2 times, most recently from e9c5fec to ead7ff0 Compare July 3, 2024 15:57
RocMarshal
RocMarshal reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the contribution.
Left a few of comments. PTAL ~

docs/content/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
@whhe
Copy link
Member Author

whhe commented Jul 4, 2024

Thanks @whhe for the contribution. Left a few of comments. PTAL ~

Thanks for your review, the documentations have been updated as suggested. PTAL.

RocMarshal
RocMarshal suggested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the update.
Left a few of comments.

docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
...k-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java Outdated Show resolved Hide resolved
...in/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseTypeMapper.java Outdated Show resolved Hide resolved
.../flink/connector/jdbc/databases/oceanbase/table/OceanBaseOracleDynamicTableSourceITCase.java Outdated Show resolved Hide resolved
@whhe
Copy link
Member Author

whhe commented Jul 8, 2024

@RocMarshal Updated. PTAL

@RocMarshal
Copy link
Contributor

@whhe nice work!
Could you help squish the commits into a single commit ? thx

@whhe whhe force-pushed the oceanbase-catalog branch from 33615e1 to 197d991 Compare July 9, 2024 02:34
RocMarshal
RocMarshal approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the hard work!
LGTM +1,
now ping @snuyanzin @eskabetxe

@whhe whhe requested a review from eskabetxe July 10, 2024 16:25
@whhe whhe force-pushed the oceanbase-catalog branch 2 times, most recently from f2a7fb8 to 3a7aec6 Compare July 15, 2024 03:15
@whhe
Copy link
Member Author

whhe commented Jul 15, 2024

@leonardBang @MartijnVisser @GOODBOY008 Can someone help with the review?

@eskabetxe
Copy link
Member

@whhe can you rebase please, and move the related code to the new OceanBase module.
we just merge a part of FLIP-449

If you need assistance, I'll be more than happy to help.

@whhe
Copy link
Member Author

whhe commented Jul 29, 2024

@whhe can you rebase please, and move the related code to the new OceanBase module. we just merge a part of FLIP-449

If you need assistance, I'll be more than happy to help.

Thank you for your reminder. I will adjust the code as soon as possible and may trouble you to review it later.

@whhe whhe force-pushed the oceanbase-catalog branch 5 times, most recently from 215698e to 6a4b58a Compare August 1, 2024 03:54
@whhe whhe force-pushed the oceanbase-catalog branch from 6a4b58a to ea354e4 Compare August 1, 2024 05:39
@whhe
Copy link
Member Author

whhe commented Aug 1, 2024

@eskabetxe PTAL

@whhe whhe requested a review from eskabetxe August 1, 2024 13:27
eskabetxe
eskabetxe approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@eskabetxe eskabetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @1996fanrui can you check

1996fanrui
1996fanrui reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the contribution, and thanks @RocMarshal & @eskabetxe for the review!

Merging

@1996fanrui 1996fanrui merged commit e198a25 into apache:main Aug 2, 2024
18 checks passed
@whhe whhe mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1996fanrui 1996fanrui 1996fanrui left review comments

@eskabetxe eskabetxe eskabetxe approved these changes

@RocMarshal RocMarshal RocMarshal approved these changes

Assignees
No one assigned
Labels
component=Connectors/JDBC component=Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whhe @RocMarshal @eskabetxe @1996fanrui