[FLINK-36816] Support source parallelism setting for JDBC connector #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Dec 3, 2024
| @@ -212,6 +212,14 @@ ON myTopic.key = MyUserTable.id; | |||
| 它决定了每个语句是否在事务中自动提交。有些 JDBC 驱动程序，特别是 | |||
| <a href="https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor">Postgres</a>，可能需要将此设置为 false 以便流化结果。</td> | |||
| </tr> | |||
| <tr> | |||
| <td><h5>scan.parallelism</h5></td> | |||
There was a problem hiding this comment.
could you add a link to some documentation for this - as there is for autocommit please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Add new option
scan.parallelismsupport for JDBC connector.Part of FLINK-33261 FLIP-367: Support Setting Parallelism for Table/SQL Sources
The change is not backward compatible for versions <= 1.18.
InputFormatProvider of(InputFormat<RowData, ?> inputFormat, @Nullable Integer sourceParallelism)was added in Flink 1.19. Therefore, we need to wait with this change until JDBC connector is no longer supporting Flink 1.18.