GEODE-10283: Remove problematic buildSrc project, replacing with incl…

…udeBuild projects (#7600)

* Extract DependencyConstraints plugin from buildSrc
* Extract japicmp plugin customization from buildSrc
* Test isolation from buildSrc
* Disable jacoco on all test facets by default

Co-authored-by: Your Name <[email protected]>

boms/geode-all-bom/build.gradle

@@ -17,10 +17,11 @@
 
 plugins {
   id 'java-platform'
-  id 'geode-dependency-constraints'
+  id 'org.apache.geode.gradle.geode-dependency-constraints'
+  id 'geode-publish-common'
 }
 
-apply from: "${rootDir}/gradle/publish-common.gradle"
+DependencyConstraints.apply(project)
 
 publishing {
   publications {

boms/geode-client-bom/build.gradle

@@ -15,10 +15,12 @@
  * limitations under the License.
  */
 
-apply from: "${rootDir}/${scriptDir}/standard-subproject-configuration.gradle"
+plugins {
+  id 'standard-subproject-configuration'
+  id 'io.spring.dependency-management'
+  id 'geode-publish-common'
+}
 
-apply plugin: "io.spring.dependency-management"
-apply from: "${project.projectDir}/../../gradle/publish-common.gradle"
 
 jar.enabled = false
 

buildSrc/build.gradle → build-tools/geode-annotation-processor/build.gradle

@@ -18,31 +18,32 @@
 
 plugins {
   id 'java'
+  id 'java-gradle-plugin'
+  id 'groovy-gradle-plugin'
+  id 'maven-publish'
+  id 'com.gradle.plugin-publish' version '0.18.0'
 }
 
 repositories {
   mavenCentral()
-  gradlePluginPortal() {
-    content {
-      includeModule('me.champeau.gradle', 'japicmp-gradle-plugin')
-    }
-  }
 }
 
 dependencies {
   testRuntimeOnly('org.apache.geode:geode-junit:1.3.0') {
     transitive(false)
   }
   implementation(gradleApi())
-  implementation('org.apache.commons:commons-lang3:3.12.0')
-  implementation('org.apache.maven:maven-artifact:3.8.5')
-  implementation('com.google.guava:guava:31.1-jre')
-  implementation('me.champeau.gradle:japicmp-gradle-plugin:0.3.0')
-  implementation('junit:junit:4.13.2')
+
+  testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.1'
+  testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
 
   testAnnotationProcessor(this.project)
 }
 
+test {
+  useJUnitPlatform()
+}
+
 sourceSets {
   main {
     java {

build-tools/geode-annotation-processor/settings.gradle

@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+rootProject.name = 'geode-annotation-processor'

build-tools/geode-build-tools/build.gradle

@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+plugins {
+  id 'java'
+  id 'java-gradle-plugin'
+  id 'groovy-gradle-plugin'
+  id 'maven-publish'
+  id 'com.gradle.plugin-publish' version '0.18.0'
+}
+
+repositories {
+  mavenCentral()
+  gradlePluginPortal()
+}
+
+dependencies {
+  implementation(gradleApi())
+
+  testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.1'
+  testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
+}
+
+test {
+  useJUnitPlatform()
+}
+
+group = 'org.apache.geode.gradle'
+version = 1.0
+
+gradlePlugin {
+  plugins.register('geode-build-tools') {
+    id = 'org.apache.geode.gradle.geode-build-tools'
+    implementationClass = 'org.apache.geode.gradle.plugins.BuildToolsPlugin'
+  }
+}

build-tools/geode-build-tools/settings.gradle

@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+rootProject.name = 'geode-build-tools'

build-tools/geode-build-tools/src/main/groovy/org/apache/geode/gradle/plugins/BuildToolsPlugin.groovy

@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.gradle.plugins;
+
+import org.gradle.api.Plugin;
+import org.gradle.api.Project;
+
+public class BuildToolsPlugin implements Plugin<Project> {
+  public void apply(Project project) {
+    // this plugin doesn't create any task by default
+  }
+}

buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy → build-tools/geode-build-tools/src/main/groovy/org/apache/geode/gradle/plugins/PasswordDialog.groovy

@@ -14,7 +14,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+package org.apache.geode.gradle.plugins
+
 import groovy.swing.SwingBuilder
+
 class PasswordDialog {
   static String askPassword(String prompt) {
     def password = ''

build-tools/geode-build-tools/src/main/groovy/org/apache/geode/gradle/plugins/TestPropertiesWriter.groovy

@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.gradle.plugins
+
+import java.io.BufferedWriter
+import java.io.File
+import java.util.Properties
+
+class TestPropertiesWriter {
+  static void writeTestProperties(File parent, String name) {
+    Properties props = new Properties()
+    props.setProperty('log-level', 'config')
+    File propsFile = new File(testResultsDir(parent, name), 'gemfire.properties')
+    BufferedWriter writer = propsFile.newWriter()
+    props.store(writer, 'Autogenerated Gemfire properties')
+  }
+
+  static File testResultsDir(File parent, String name) {
+    return new File(parent, name)
+  }
+}
+
+

build-tools/geode-dependency-management/build.gradle

@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+plugins {
+  id 'java'
+  id 'groovy-gradle-plugin'
+}
+
+repositories {
+  mavenCentral()
+  gradlePluginPortal()
+}
+
+dependencies {
+  implementation(gradleApi())
+}
+
+sourceSets {
+  main {
+    java {
+      srcDirs = []
+    }
+    groovy {
+      srcDirs += ['src/main/java']
+    }
+  }
+}
+
+gradlePlugin {
+  plugins.register('geode-dependency-constraints') {
+    id = 'org.apache.geode.gradle.geode-dependency-constraints'
+    implementationClass = 'org.apache.geode.gradle.plugins.DependencyConstraintsPlugin'
+  }
+}

build-tools/geode-dependency-management/settings.gradle

@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+rootProject.name = 'geode-dependency-management'

buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy → build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy

@@ -15,12 +15,11 @@
 
 package org.apache.geode.gradle.plugins
 
-import org.gradle.api.Plugin
 import org.gradle.api.Project
 
-class DependencyConstraints implements Plugin<Project> {
-  /** By necessity, the version of those plugins used in the build-scripts are defined in the
-   * buildscript {} configuration in the root project's build.gradle. */
+class DependencyConstraints {
+/** By necessity, the version of those plugins used in the build-scripts are defined in the
+ * buildscript {} configuration in the root project's build.gradle. */
   static Map<String,String> disparateDependencies = initExternalDependencies()
 
   static String get(String name) {
@@ -75,7 +74,6 @@ class DependencyConstraints implements Plugin<Project> {
     return deps
   }
 
-  @Override
   void apply(Project project) {
     def dependencySet = { Map<String, String> group_and_version, Closure closure ->
       DependencySetHandler delegate =

build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraintsPlugin.groovy

@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.gradle.plugins
+
+import org.gradle.api.Plugin
+import org.gradle.api.Project
+
+class DependencyConstraintsPlugin implements Plugin<Project> {
+
+  @Override
+  void apply(Project project) {
+    project.extensions.create("DependencyConstraints", DependencyConstraints)
+  }
+}