[GOBBLIN-1981] Renames writer.path.type config name as it has a type conflict with w…

[Will-Lo]

…riter.path

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-1981

Description

• Here are some details about my PR, including screenshots (if applicable):

There are some properties in Gobblin that are not typesafe when put in a Config class object, this causes issues with GaaS passing those properties to Gobblin cluster.
To resolve this, we should fix the property names so that there are no conflicts.

The property in particular we want to change is writer.file.path.type that conflicts with writer.file.path due to sharing the same prefix but expanding the key when there's a value mapped to it (making it not type safe as it can't transform a string value to a map). We can rename this property to writer.file.pathType.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  Backwards compatible

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18fba9e) 47.60% compared to head (1ed9fad) 48.95%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3852      +/-   ##
============================================
+ Coverage     47.60%   48.95%   +1.35%     
+ Complexity    11065     8065    -3000     
============================================
  Files          2159     1489     -670     
  Lines         85464    59151   -26313     
  Branches       9497     6815    -2682     
============================================
- Hits          40682    28960   -11722     
+ Misses        41080    27497   -13583     
+ Partials       3702     2694    -1008     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.