Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6409] fix(client-python): Change to use GenericFileset for the return value of fileset catalog #6410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR changes the return value to GenericFileset for fileset operation.

Why are the changes needed?

Previously, it returns the plain fileset dto, so that it cannot support some operations like get credentials.

Fix: #6409

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@jerryshao jerryshao added the branch-0.8 Automatically cherry-pick commit to branch-0.8 label Feb 8, 2025
@jerryshao jerryshao requested review from FANNG1 and yuqi1129 February 8, 2025 11:10
@jerryshao jerryshao self-assigned this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.8 Automatically cherry-pick commit to branch-0.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] FilesetCatalog in Python doesn't return GenericFileset
1 participant