HBASE-29036 Backport missing UI patches to branch-2.6 #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e)
…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)
Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa)
…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi @PDavid please let me know once this PR is ready for review |
|
Hi @NihalJain, |
|
Results of local testings:
|
Oh, I haven't checked the rest ui while testing the branch-2 patch... Maybe we have the same problem for branch-2... |
|
Many thanks @NihalJain for testing this. 👍 Would you like if I fix this under this Jira and PR or would you prefer having the fix under the separate Jira. Both are OK for me. |
|
I found one possible fix for the REST UI is broken (static resources are not loaded) issue: copy the I'd prefer to fix it after the Bootstrap upgrade is merged as otherwise it has to be copied again with the new CSS, JS files. |
Sure sounds good. |
NihalJain
approved these changes
Jan 6, 2025
|
@PDavid We are good to merge this right? Should I go ahead now? |
|
@NihalJain I think this should be finished but let me do another round of testing just to make sure. Will comment again when done. |
|
Dropped a mail on dev thread to decide on whether we want to take this and other related changes in before the upcoming release. https://lists.apache.org/thread/1srh98tymv79zdh7fwkljddd6bd0rntt FYI @PDavid CC: #6526 |
@NihalJain OK, I tested this, looks good to me. Of course let's wait the dev discussion if we need this in the release. |
apurtell
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the following patches which were missing on
branch-2.6branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.Each commit message contains from which commit it was cherry-picked from.