Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-29055 Remove the useless parameter from RootProcedureState #6573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

HBASE-29055 Remove the useless parameter from RootProcedureState #6573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ private void executeProcedure(Procedure<TEnvironment> proc) {
}
do {
// Try to acquire the execution
if (!procStack.acquire(proc)) {
if (!procStack.acquire()) {
if (procStack.setRollback()) {
// we have the 'rollback-lock' we can start rollingback
switch (executeRollback(rootProcId, procStack)) {
Expand Down Expand Up @@ -1513,7 +1513,7 @@ private void executeProcedure(Procedure<TEnvironment> proc) {
default:
throw new UnsupportedOperationException();
}
procStack.release(proc);
procStack.release();

if (proc.isSuccess()) {
// update metrics on finishing the procedure
Expand Down
4 changes: 2 additions & 2 deletions hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ protected synchronized RemoteProcedureException getException() {
/**
* Called by the ProcedureExecutor to mark the procedure step as running.
*/
protected synchronized boolean acquire(Procedure<TEnvironment> proc) {
protected synchronized boolean acquire() {
if (state != State.RUNNING) {
return false;
}
Expand All @@ -147,7 +147,7 @@ protected synchronized boolean acquire(Procedure<TEnvironment> proc) {
/**
* Called by the ProcedureExecutor to mark the procedure step as finished.
*/
protected synchronized void release(Procedure<TEnvironment> proc) {
protected synchronized void release() {
running--;
}

Expand Down