-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPCLIENT-2356: Extend Auth API and authentication Logic to enable m… #614
Conversation
@stoty Your changes are mostly intact. I folded |
Thank you @ok2c . Using a default method instead of a new interface is a definite improvement over my version. Two small issues:
|
I was also planning to revert the disabled API check maven plugin before commit. |
@stoty Commit message and log statements have been corrected. Please do another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
I am going to merge the PR later today unless someone objects. @michael-o Please do a post-commit review. If you see anything wrong with the change-set I will revert it. |
Will review this night |
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthExchange.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
Outdated
Show resolved
Hide resolved
…utual authentication
@michael-o Corrected. Please do another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utual authentication