-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the G1 Humongous Allocation BUG, when the connection run all the … #465
Conversation
…time , will generate many G1 Humongous Allocation , and OOM
@crazylulululu Do you think you could add a test case for this defect to |
OK, use this.tmpBuf.position() + extra as the requiredCapacity is error , this will occur large size object frequently ,and cause GC |
@crazylulululu Would you be willing to add a test case to the proposed patch or not? |
…n run all the time , will generate many G1 Humongous Allocation , and OOM
@ok2c , I have add the test case ,please help to check , thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crazylulululu Awesome. The test case look good.
@@ -158,6 +158,10 @@ void decodeString(final ByteArrayBuffer buffer, final ByteBuffer src) throws HPa | |||
} | |||
} | |||
|
|||
public int getTmpBufSize() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crazylulululu This method does not need to be public. Could you please make package private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ok2c , I have changed ,thanks
… Humongous Allocation and OOM (#465)
@crazylulululu Merged to |
the logic is incorrect ,if a connection is used continuously , it will generate the G1 Humongous Allocation , and GC will be particularly frequent, please fix this bug as soon as possible.