Handle overflow in Deadline calculation to ensure correct behavior for large time values. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
reviewed
Jan 10, 2025
| @@ -83,8 +83,11 @@ public class Deadline { | |||
| */ | |||
| public static Deadline calculate(final long timeMillis, final TimeValue timeValue) { | |||
| if (TimeValue.isPositive(timeValue)) { | |||
| // TODO handle unlikely overflow | |||
| final long deadline = timeMillis + timeValue.toMilliseconds(); | |||
| final long timeToAdd = timeValue.toMilliseconds(); | |||
There was a problem hiding this comment.
@arturobernalg Should not this do the same, just with a bit less code? I also think timeToAdd > 0 and deadline < 0 are unnecessary.
if (TimeValue.isPositive(timeValue)) {
return Deadline.fromUnixMilliseconds(timeMillis +
Math.min(timeValue.toMilliseconds(), Long.MAX_VALUE - timeMillis));
}
return Deadline.MAX_VALUE;
There was a problem hiding this comment.
@ok2c Updated the implementation as suggested. Thanks for the feedback!
…r large time values.
arturobernalg
force-pushed
the
deadline
branch
from
a91e3b8 to
88d08b5
Compare
ok2c
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes overflow handling in Deadline calculation to ensure proper behavior when adding large time values, returning Deadline.MAX_VALUE in case of overflow.