Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use static MetaField schema for incr query #252

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jan 20, 2025

Description

Avoid resolving table schema for composing incremental query filters.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added the refactor Code refactoring without any functionality or behavior change label Jan 20, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (4575ccd) to head (d5127ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   92.28%   92.13%   -0.15%     
==========================================
  Files          40       40              
  Lines        1840     1844       +4     
==========================================
+ Hits         1698     1699       +1     
- Misses        142      145       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit c47f52a into apache:main Jan 20, 2025
10 checks passed
@xushiyan xushiyan deleted the metafield-schema branch January 20, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring without any functionality or behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant