Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename crate hudi-tests to hudi-test #262

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jan 24, 2025

Description

"tests" can imply containing test cases. Rename hudi-tests to hudi-test to avoid potential confusion.

Replace custom maintained assert_not! with standard lib macro assert!. And remove unused macro assert_approx_eq!.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase labels Jan 24, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (f722508) to head (d450516).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          40       40           
  Lines        1967     1967           
=======================================
  Hits         1794     1794           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit 04fe00d into apache:main Jan 24, 2025
12 checks passed
@xushiyan xushiyan deleted the refactor-test-crate branch January 24, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant