AWS: Undeprecate botocore_session
#1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've deprecated this a while ago, because as the configuration should only pass in strings, and not Python objects. However, it was pretty complex to find a reasonable alternative for this. For example: apache#1299 Therefore, I think we should undo this deprecation for now.
kevinjqliu
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
LGTM!
This was brought up in the 0.9.0 release discuss thread on devlist
https://lists.apache.org/thread/rr8lcf96jl6079dz6vfkwr5spbvlxzpm
geruh
approved these changes
Feb 20, 2025
|
Thanks @kevinjqliu and @geruh for the quick review 🚀 |
3 tasks
kevinjqliu
pushed a commit
that referenced
this pull request
Feb 21, 2025
This PR deprecates one of the three items that were planned for the 0.9.0 release. All items marked for removal: - [x] Table name reference in scan expression <https://github.com/apache/iceberg-python/blob/efc8b5ac0f16717f776e034ecf9a9e9bdabd8424/pyiceberg/expressions/parser.py#L95> - [x] REST catalog client AUTH_URL (#1691) <https://github.com/apache/iceberg-python/blob/efc8b5ac0f16717f776e034ecf9a9e9bdabd8424/pyiceberg/catalog/rest.py#L324> - [x] botocore session (#1692) <https://github.com/apache/iceberg-python/blob/efc8b5ac0f16717f776e034ecf9a9e9bdabd8424/pyiceberg/catalog/__init__.py#L790> Currently there are three items marked for release. However, based on the ongoing [discussion](https://lists.apache.org/thread/rr8lcf96jl6079dz6vfkwr5spbvlxzpm), it appears that the other two items. have not yet been replaced with a proper solution. As a result, this PR only addresses the deprecation of `Table name reference in scan expression` while we await further resolution on the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've deprecated this a while ago, because as the configuration should only pass in strings, and not Python objects.
However, it was pretty complex to find a reasonable alternative for this. For example: #1299
Therefore, I think we should undo this deprecation for now.