-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Refactor site navigation bar #12289
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok i also double checked that moving from one tab to another doesn't affect the URL. For example, "Table Spec" is moved from under "Project" to under "Specification", but the URL is still There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the only URL that changed (removed) is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, the
catalog.md
was always a bit lonely as it was the only concepts page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually favor a little more on keeping
catalog.md
as a separate page, as the content is more than just terms. just keep this page in the newSpecification
section. Catalog is an important concept and deserves more details that the content page captured than simple term definition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree catalogs deserve more details but having both catalogs and terms looks confusing to me. Isn't catalog a term?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree that catalog is a term, which is good to be clarified in the
terms
page. but the content also talked a lot more about implementations. anyway, I can go either way on this one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: what about taking
Catalog
one level up?Currently its the first subtab under "Terms". Would it make sense to make it its on sub in "Specification"?