[1.7.x] Fix {LICENSE,NOTICE} for GCP Bundle
#12359
Merged
+326
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Feb 21, 2025
| Project URL: https://github.com/google/gson/gson | ||
| License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| Group: com.google.errorprone Name: error_prone_annotations Version: 2.18.0 | ||
| Group: com.google.errorprone Name: error_prone_annotations Version: 2.33.0 |
There was a problem hiding this comment.
I wonder if this should be 2.35.1? https://github.com/apache/iceberg/blob/1.7.x/gradle/libs.versions.toml#L41
There was a problem hiding this comment.
I checked with :iceberg-gcp-bundle:dependencies and I also find 2.33.0 for error_prone_annotations (same as @Fokko ).
nastra
approved these changes
Feb 21, 2025
jbonofre
approved these changes
Feb 21, 2025
| Project URL: https://github.com/google/gson/gson | ||
| License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| Group: com.google.errorprone Name: error_prone_annotations Version: 2.18.0 | ||
| Group: com.google.errorprone Name: error_prone_annotations Version: 2.33.0 |
There was a problem hiding this comment.
I checked with :iceberg-gcp-bundle:dependencies and I also find 2.33.0 for error_prone_annotations (same as @Fokko ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.