Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11685][Agent] Only use configuration files to provide IP address #11686

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Jan 19, 2025

Fixes #11685

Motivation

Prevent agent IP uncertainty when the machine has multiple IPs

Modifications

Only use configuration files to provide IP address

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No needed doc

@justinwwhuang justinwwhuang added this to the 2.2.0 milestone Jan 19, 2025
@justinwwhuang justinwwhuang self-assigned this Jan 19, 2025
@dockerzhang dockerzhang merged commit 3d754fa into apache:master Jan 20, 2025
11 checks passed
@justinwwhuang justinwwhuang deleted the b11685 branch January 20, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Agent needs to modify the logic of confirming its own IP address
4 participants