[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to HTTP #8941

haibo-duan · 2023-09-20T02:57:55Z

Prepare a Pull Request

(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes [Improve][Manager] Pulsar - Modify the calling method from SDK to HTTP #8674

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Modify the pulsar calling method from SDK to HTTP.

Verifying this change

(Please pick either of the following options)

This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:

(example:)
- Added integration tests for end-to-end deployment with large payloads (10MB)
- Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

… HTTP

dockerzhang · 2023-09-20T03:16:53Z

@haibo-duan please rebase from the master to solve the conflict, thanks.

…ceOperator

dockerzhang · 2023-09-20T07:04:20Z

Do we need to remove the pulsar dependency in the pom for this PR?

inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/pulsar/PulsarResourceOperator.java

…to INLONG-8674

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java

aloyszhang

Overall LGTM, left some comments, PTAL

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java

...r/manager-service/src/test/java/org/apache/inlong/manager/service/queue/PulsarUtilsTest.java

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java

aloyszhang

Nice contribution!

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java

dependabot bot and others added 2 commits May 1, 2022 17:10

[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to…

c94f632

… HTTP

github-actions bot added the component/manager label Sep 20, 2023

haibo-duan added 8 commits September 20, 2023 12:55

Merge branch 'master' into INLONG-8674

51eeeac

[INLONG-8674][Manager] add license

2f421e0

[INLONG-8674][Manager] fix format violations

145cff1

[INLONG-8674][Manager] fix format violations PulsarUtilsTest

b83d7d9

[INLONG-8674][Manager] fix format violations PulsarUtils PulsarResour…

3eb4d6d

…ceOperator

[INLONG-8674][Manager] fix format violations PulsarUtils PulsarResour…

297d53e

…ceOperator

[INLONG-8674][Manager] fix format violations PulsarUtils PulsarResour…

aafa196

…ceOperator

[INLONG-8674][Manager] fix format violations PulsarUtils PulsarResour…

89c1df0

…ceOperator

haibo-duan added 6 commits September 21, 2023 19:47

[INLONG-8674][Manager] remove the pulsar dependency in the pom

59bb210

[INLONG-8674][Manager] remove the pulsar dependency in the pom

810367e

[INLONG-8674][Manager] remove the pulsar dependency in the pom

b82b5c8

[INLONG-8674][Manager] remove the pulsar dependency in the pom

dfa8ca6

[INLONG-8674][Manager] remove the pulsar dependency in the pom

d332832

github-actions bot added component/tubemq component/dataproxy component/dashboard component/agent component/audit component/sort component/sdk labels Sep 28, 2023

haibo-duan added 3 commits September 28, 2023 16:26

[INLONG-8674][Manager] resolve conflicts

6176fe4

Merge branch 'INLONG-8674' of https://github.com/haibo-duan/inlong in…

2849bdb

…to INLONG-8674

github-actions bot removed the component/tubemq label Sep 28, 2023

haibo-duan added 5 commits October 31, 2023 20:43

[INLONG-8676][Manager] mvn spotless:apply

c6f3a5b

[INLONG-8676][Manager] mvn spotless:apply

7507db9

[INLONG-8676][Manager] Add netty configuration in pom file

ad5345f

[INLONG-8676][Manager] remove netty

375d0c7

[INLONG-8676][Manager] remove netty

3bba643

aloyszhang reviewed Nov 2, 2023

View reviewed changes

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Outdated Show resolved Hide resolved

aloyszhang reviewed Nov 2, 2023

View reviewed changes

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Outdated Show resolved Hide resolved

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Outdated Show resolved Hide resolved

aloyszhang reviewed Nov 2, 2023

View reviewed changes

...r/manager-service/src/test/java/org/apache/inlong/manager/service/queue/PulsarUtilsTest.java Outdated Show resolved Hide resolved

[INLONG-8676][Manager] fix comments

158f152

aloyszhang reviewed Nov 2, 2023

View reviewed changes

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Outdated Show resolved Hide resolved

haibo-duan added 6 commits November 2, 2023 20:35

[INLONG-8676][Manager] fix comments

f84c5ce

[INLONG-8676][Manager] fix comments

f6bd178

[INLONG-8676][Manager] fix comments

360682b

[INLONG-8676][Manager] add sleep time

02bea80

[INLONG-8676][Manager] add sleep time

a4cf30d

[INLONG-8676][Manager] Modify constant name

f8db827

aloyszhang previously approved these changes Nov 6, 2023

View reviewed changes

dockerzhang previously approved these changes Nov 6, 2023

View reviewed changes

fuweng11 reviewed Nov 7, 2023

View reviewed changes

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Outdated Show resolved Hide resolved

...rvice/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarUtils.java Show resolved Hide resolved

[INLONG-8676][Manager] Modify variable name.

1310ac0

haibo-duan dismissed stale reviews from dockerzhang and aloyszhang via 1310ac0 November 13, 2023 02:32

aloyszhang approved these changes Nov 15, 2023

View reviewed changes

fuweng11 approved these changes Nov 15, 2023

View reviewed changes

dockerzhang approved these changes Nov 17, 2023

View reviewed changes

haibo-duan added 2 commits November 17, 2023 16:10

Merge branch 'master' of https://github.com/apache/inlong

c0234b5

Merge branch 'master' into INLONG-8674

c44ede9

vernedeng approved these changes Nov 17, 2023

View reviewed changes

haifxu approved these changes Nov 28, 2023

View reviewed changes

dockerzhang merged commit d8c8380 into apache:master Nov 28, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to HTTP #8941

[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to HTTP #8941

haibo-duan commented Sep 20, 2023 •

edited by dockerzhang

Loading

dockerzhang commented Sep 20, 2023

dockerzhang commented Sep 20, 2023

aloyszhang left a comment

aloyszhang left a comment

[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to HTTP #8941

[INLONG-8674][Manager] Pulsar - Modify the calling method from SDK to HTTP #8941

Conversation

haibo-duan commented Sep 20, 2023 • edited by dockerzhang Loading

Prepare a Pull Request

Motivation

Modifications

Verifying this change

Documentation

dockerzhang commented Sep 20, 2023

dockerzhang commented Sep 20, 2023

aloyszhang left a comment

Choose a reason for hiding this comment

aloyszhang left a comment

Choose a reason for hiding this comment

haibo-duan commented Sep 20, 2023 •

edited by dockerzhang

Loading