Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9388][Sort] Updated version of embedded-redis in sort-connector-redis #9389

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[INLONG-9388][Sort] Updated version of embedded-redis in sort-connector-redis #9389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59aa34d
[INLONG-9388][Sort] Updated version of embedded-redis in sort-connect…
hnrainll Dec 1, 2023
0445262
make this version as one pom property
hnrainll Dec 4, 2023
c029875
move property to root pom
hnrainll Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/redis/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.github.kstyrc</groupId>
<groupId>com.github.codemonstur</groupId>
<artifactId>embedded-redis</artifactId>
<version>0.6</version>
<version>1.1.0</version>
dockerzhang marked this conversation as resolved.
Show resolved Hide resolved
<scope>test</scope>
</dependency>
<dependency>
Expand Down
7 changes: 4 additions & 3 deletions ...1.13/sort-connectors/redis/src/test/java/org/apache/inlong/sort/redis/RedisTableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import redis.clients.jedis.Jedis;
import redis.embedded.RedisServer;

import java.io.IOException;
import java.util.Arrays;
import java.util.concurrent.TimeUnit;

Expand All @@ -45,14 +46,14 @@ public class RedisTableTest {
private static RedisServer redisServer;

@BeforeClass
public static void setup() {
public static void setup() throws IOException {
redisPort = NetUtils.getAvailablePort();
redisServer = RedisServer.builder().setting("maxmemory 128m").port(redisPort).build();
redisServer = RedisServer.newRedisServer().setting("maxmemory 128m").port(redisPort).build();
redisServer.start();
}

@AfterClass
public static void cleanup() {
public static void cleanup() throws IOException {
if (redisServer != null) {
redisServer.stop();
}
Expand Down