Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9972][Sort] Pulsar connector support authentication when connecting to Pulsar cluster #9973

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Apr 11, 2024

Motivation

According to https://pulsar.apache.org/docs/next/security-jwt/
Some pulsar cluster have authentication opened in some cases, the sort connector should support authentication

Modifications

Added two parameter used in authentication
1、pulsar client auth plugin class name, e.g. org.apache.pulsar.client.impl.auth.AuthenticationToken
2、pulsar client auth params, the value should be compatible with the clientAuthPluginClassName, see also in
https://pulsar.apache.org/docs/next/security-jwt/

Verifying this change

Tested in pulsar cluster with authentication and the ExtractNode teste in PulsarSqlParserTest

@aloyszhang aloyszhang added this to the 1.12.0 milestone Apr 11, 2024
@EMsnap EMsnap marked this pull request as draft April 11, 2024 04:08
@baomingyu baomingyu requested a review from aloyszhang April 13, 2024 06:26
@EMsnap EMsnap marked this pull request as ready for review April 15, 2024 01:45
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMsnap EMsnap merged commit b1de06b into apache:master Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Pulsar connetor should support authentication when connecting to Pulsar cluster
4 participants