Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Remove DataNode Test #13809

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

HxpSerein
Copy link
Collaborator

Description

Improve remove datanode related UT/IT for complex test scenarios in region migration tests.

  • Task management and conflict checking
  • Running/ReadOnly nodes can be rejoined as new nodes after being removed
  • Nodes and their region statuses that failed to remove are correctly rolled back

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 063fddd into apache:master Oct 30, 2024
26 of 27 checks passed
HxpSerein added a commit to HxpSerein/iotdb that referenced this pull request Dec 3, 2024
OneSizeFitsQuorum added a commit that referenced this pull request Dec 6, 2024
…14301)

* Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing #13517

(cherry picked from commit 5599859)

* Remove datanode optimization (#13559)

(cherry picked from commit cc73946)

* Split CnToDnRequestType to sync and async & Add check for adding new request type (#13660)

(cherry picked from commit 8187498)

* Enhance Remove DataNode Test (#13809)

(cherry picked from commit 063fddd)

* [remove datanode] Identify and display invalid nodes before removing #13987

(cherry picked from commit 387b4bf)

* [remove datanode] Fixed jvm heap memory in remove datanode script (#13983)

(cherry picked from commit 78e6f3a)

* [remove datanode] Enhance remove message on environment with only ConfigNode #14007

(cherry picked from commit db7c522)

* Remove useless log "datanodeId -1" #14035

(cherry picked from commit 8a92aaf)

* [remove datanode] Log the node information when submitting RegionMigrateProcedure (#14051)

(cherry picked from commit e437ef3)

* [remove datanode] Enhance remove message on environment with only ConfigNode #14123

(cherry picked from commit f3afc20)

* [remove datanode] Refuse to remove when there are any other unknown or readonly DataNodes in the consensus group (#14145)

* add uknown check

* remove useless check

(cherry picked from commit adcedc0)

* Fix stopping cn leader stuck when region region migration #14175

Signed-off-by: OneSizeFitQuorum <[email protected]>
(cherry picked from commit 9b22f7c)

* [remove datanode] Do not allow regions to inherit the Removing state from datanode (#14185)

(cherry picked from commit 8a6405c)

* [remove datanode] Do not disable the entire region group for one removing region (#14241)

* fix disabled

* fix disabled

(cherry picked from commit 041d292)

* [remove datanode] Not re-submit region migration procedure when leader change or reboot #14277

(cherry picked from commit d101d76)

* Fix ConfignNode LoadManager NPE when removing datanodes #14016

Signed-off-by: OneSizeFitQuorum <[email protected]>
(cherry picked from commit b39c325)

* Fix ConfigNode Partition Metric NPE bug #14144

Signed-off-by: OneSizeFitQuorum <[email protected]>
(cherry picked from commit 4a76dfb)

* Enhance procedure recover policy

(cherry picked from commit 496c62e)

* remove table

* fix IT

---------

Co-authored-by: Li Yu Heng <[email protected]>
Co-authored-by: Potato <[email protected]>
@HxpSerein HxpSerein deleted the remove_dn_test branch December 6, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants