-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Remove DataNode Test #13809
Merged
Merged
Enhance Remove DataNode Test #13809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeITFramework.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/iotdb/confignode/manager/load/cache/node/DataNodeHeartbeatCache.java
Show resolved
Hide resolved
...fignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/region/RegionCache.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeITFramework.java
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManager.java
Outdated
Show resolved
Hide resolved
OneSizeFitsQuorum
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HxpSerein
added a commit
to HxpSerein/iotdb
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 063fddd)
OneSizeFitsQuorum
added a commit
that referenced
this pull request
Dec 6, 2024
…14301) * Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing #13517 (cherry picked from commit 5599859) * Remove datanode optimization (#13559) (cherry picked from commit cc73946) * Split CnToDnRequestType to sync and async & Add check for adding new request type (#13660) (cherry picked from commit 8187498) * Enhance Remove DataNode Test (#13809) (cherry picked from commit 063fddd) * [remove datanode] Identify and display invalid nodes before removing #13987 (cherry picked from commit 387b4bf) * [remove datanode] Fixed jvm heap memory in remove datanode script (#13983) (cherry picked from commit 78e6f3a) * [remove datanode] Enhance remove message on environment with only ConfigNode #14007 (cherry picked from commit db7c522) * Remove useless log "datanodeId -1" #14035 (cherry picked from commit 8a92aaf) * [remove datanode] Log the node information when submitting RegionMigrateProcedure (#14051) (cherry picked from commit e437ef3) * [remove datanode] Enhance remove message on environment with only ConfigNode #14123 (cherry picked from commit f3afc20) * [remove datanode] Refuse to remove when there are any other unknown or readonly DataNodes in the consensus group (#14145) * add uknown check * remove useless check (cherry picked from commit adcedc0) * Fix stopping cn leader stuck when region region migration #14175 Signed-off-by: OneSizeFitQuorum <[email protected]> (cherry picked from commit 9b22f7c) * [remove datanode] Do not allow regions to inherit the Removing state from datanode (#14185) (cherry picked from commit 8a6405c) * [remove datanode] Do not disable the entire region group for one removing region (#14241) * fix disabled * fix disabled (cherry picked from commit 041d292) * [remove datanode] Not re-submit region migration procedure when leader change or reboot #14277 (cherry picked from commit d101d76) * Fix ConfignNode LoadManager NPE when removing datanodes #14016 Signed-off-by: OneSizeFitQuorum <[email protected]> (cherry picked from commit b39c325) * Fix ConfigNode Partition Metric NPE bug #14144 Signed-off-by: OneSizeFitQuorum <[email protected]> (cherry picked from commit 4a76dfb) * Enhance procedure recover policy (cherry picked from commit 496c62e) * remove table * fix IT --------- Co-authored-by: Li Yu Heng <[email protected]> Co-authored-by: Potato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve remove datanode related UT/IT for complex test scenarios in region migration tests.