Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental wrong error msg #13902

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Fix accidental wrong error msg #13902

merged 3 commits into from
Oct 25, 2024

Conversation

JackieTien97
Copy link
Contributor

We may encounter some error msgs like the following:
image
which is caused by async error passing of Query Engine, in this pr, I try to record exact native execption and passing it.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.79%. Comparing base (4e79200) to head (3d1f9e3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ne/execution/fragment/FragmentInstanceContext.java 0.00% 5 Missing ⚠️
.../iotdb/db/queryengine/execution/driver/Driver.java 0.00% 3 Missing ⚠️
...db/queryengine/execution/driver/DriverContext.java 0.00% 3 Missing ⚠️
...ngine/execution/schedule/AbstractDriverThread.java 50.00% 2 Missing ⚠️
...iotdb/commons/exception/QueryTimeoutException.java 0.00% 2 Missing ⚠️
...ueryengine/exception/MemoryNotEnoughException.java 0.00% 1 Missing ⚠️
.../execution/fragment/FragmentInstanceExecution.java 0.00% 1 Missing ⚠️
...ueryengine/execution/schedule/DriverScheduler.java 91.66% 1 Missing ⚠️
...tion/schedule/DriverTaskTimeoutSentinelThread.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #13902   +/-   ##
=========================================
  Coverage     39.79%   39.79%           
  Complexity       71       71           
=========================================
  Files          4159     4160    +1     
  Lines        263425   263437   +12     
  Branches      32083    32083           
=========================================
+ Hits         104818   104831   +13     
+ Misses       158607   158606    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 0db4ec4 into master Oct 25, 2024
28 of 29 checks passed
@JackieTien97 JackieTien97 deleted the ty/FixErrorPass branch October 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant