Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect the aggregation queries when there is no devices or no data partitions. #13907

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 24, 2024

Description

As the title.

Before this pr, select count(*), count(num), sum(num) from table0 where device='d_not_exist' or select count(*), count(num), sum(num) from table0 where time>now() will return empty. In this pr, the sql will return 0,0,null


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 72.58065% with 17 lines in your changes missing coverage. Please review.

Project coverage is 39.78%. Comparing base (e363388) to head (e66de62).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
.../relational/TableAggregationTableScanOperator.java 0.00% 8 Missing ⚠️
...nner/optimizations/PushPredicateIntoTableScan.java 0.00% 4 Missing ⚠️
...nner/distribute/TableDistributedPlanGenerator.java 95.12% 2 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 0.00% 1 Missing ⚠️
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 0.00% 1 Missing ⚠️
...queryengine/plan/relational/analyzer/Analysis.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13907      +/-   ##
============================================
- Coverage     39.79%   39.78%   -0.02%     
  Complexity       71       71              
============================================
  Files          4158     4159       +1     
  Lines        263375   263414      +39     
  Branches      32077    32085       +8     
============================================
- Hits         104823   104800      -23     
- Misses       158552   158614      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@JackieTien97 JackieTien97 merged commit 80cd9f7 into master Oct 25, 2024
28 of 29 checks passed
@JackieTien97 JackieTien97 deleted the fix_subquery branch October 25, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants