Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe: validate all pipe parameters before alter #13932

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Pipe: validate all pipe parameters before alter #13932

merged 2 commits into from
Oct 29, 2024

Conversation

SteveYurongSu
Copy link
Member

As title.

@SteveYurongSu SteveYurongSu self-assigned this Oct 28, 2024
@SteveYurongSu
Copy link
Member Author

@VGalaxies PTAL

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (ccc44e2) to head (90dac24).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 71 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #13932      +/-   ##
============================================
- Coverage     39.67%   39.65%   -0.02%     
  Complexity       71       71              
============================================
  Files          4183     4186       +3     
  Lines        264141   264560     +419     
  Branches      32149    32205      +56     
============================================
+ Hits         104785   104921     +136     
- Misses       159356   159639     +283

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VGalaxies
VGalaxies reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better add some tests in org.apache.iotdb.pipe.it.autocreate.IoTDBPipeAlterIT

...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteveYurongSu SteveYurongSu merged commit d35da56 into master Oct 29, 2024
28 of 29 checks passed
@SteveYurongSu SteveYurongSu deleted the validate-before-alter branch October 29, 2024 13:42
SteveYurongSu added a commit that referenced this pull request Oct 29, 2024
@SteveYurongSu
Pipe: validate all pipe parameters before alter (#13932)
59fda9d 
(cherry picked from commit d35da56)
SteveYurongSu added a commit that referenced this pull request Oct 29, 2024
@SteveYurongSu
Pipe: validate all pipe parameters before alter (#13932) (#13958)
a19fda5 
(cherry picked from commit d35da56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGalaxies VGalaxies VGalaxies left review comments

@luoluoyuyu luoluoyuyu luoluoyuyu approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveYurongSu @VGalaxies @luoluoyuyu