Implement distinct in AggFunction #14623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Wei-hao-Li
commented
Jan 3, 2025
Wei-hao-Li
commented
- Support all agg-functions include UDAF.
- This PR only contains the basic implement, the optimizers will be supported in next PR.
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
JackieTien97
requested changes
Jan 6, 2025
...e/iotdb/db/queryengine/execution/operator/source/relational/aggregation/AggregationMask.java
Outdated
Show resolved
Hide resolved
...otdb/db/queryengine/execution/operator/source/relational/aggregation/AccumulatorFactory.java
Outdated
Show resolved
Hide resolved
...e/iotdb/db/queryengine/execution/operator/source/relational/aggregation/AggregationMask.java
Outdated
Show resolved
Hide resolved
...db/db/queryengine/execution/operator/source/relational/aggregation/MaskedRecordIterator.java
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/access/RecordIterator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
Signed-off-by: Weihao Li <[email protected]>
|
I noticed that In Trino there's a MarkDistinctOperator, does it have something to do with Distinct Function? |
Yes, it is another implement of AggFunc-distinct, it will be introduced to our code in next optimizer PR (You can see design doc of this feature to see more details). |
OK👍 |
Signed-off-by: Weihao Li <[email protected]> Signed-off-by: Weihao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.