Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone value array when insert non aligned tablet with null #14643

Merged

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Jan 7, 2025

Description

As title

@SteveYurongSu SteveYurongSu self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.38%. Comparing base (cfc15de) to head (a0a9dd2).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #14643    +/-   ##
==========================================
  Coverage     39.38%   39.38%            
  Complexity      193      193            
==========================================
  Files          4367     4374     +7     
  Lines        276693   277201   +508     
  Branches      33764    33848    +84     
==========================================
+ Hits         108977   109189   +212     
- Misses       167716   168012   +296     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@jt2594838 jt2594838 merged commit 5bd1ead into master Jan 10, 2025
37 of 38 checks passed
@jt2594838 jt2594838 deleted the clone_value_array_when_insert_nonaligned_tablet_with_null branch January 10, 2025 11:10
HTHou added a commit that referenced this pull request Jan 13, 2025
* Clone value array when insert non aligned tablet with null

* Fix UT

* Add recover wal IT
jt2594838 pushed a commit that referenced this pull request Jan 13, 2025
…14679)

* Clone value array when insert non aligned tablet with null

* Fix UT

* Add recover wal IT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants