Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip subquery plan if subqueryExpression List is empty for efficiency #14647

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

lancelly
Copy link
Contributor

@lancelly lancelly commented Jan 7, 2025

No description provided.

Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 39.38%. Comparing base (2669666) to head (5e37dc1).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...ngine/plan/relational/planner/SubqueryPlanner.java 54.54% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14647   +/-   ##
=========================================
  Coverage     39.37%   39.38%           
  Complexity      193      193           
=========================================
  Files          4367     4367           
  Lines        276755   276756    +1     
  Branches      33789    33794    +5     
=========================================
+ Hits         108986   109005   +19     
+ Misses       167769   167751   -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes merged commit bdf36ba into master Jan 10, 2025
19 of 20 checks passed
@Beyyes Beyyes deleted the skip_empty_subquery_plan branch January 10, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants