Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[To dev/1.3] Let the DataPartitionTable be automatically cleanable (#14737) #14759

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[To dev/1.3] Let the DataPartitionTable be automatically cleanable (#14737) #14759

merged 2 commits into from
Jan 23, 2025

Conversation

CRZbulabula
Copy link
Contributor

As the title described.

CRZbulabula and others added 2 commits January 23, 2025 10:43
@CRZbulabula
Let the DataPartitionTable be automatically cleanable (#14737)
bfe4bd6 
* seems finished

* Use periodic procedure 4 partition table cleaner

* Update ThreadName.java
@CRZbulabula
Update PartitionTableAutoCleaner.java
68f26b9
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.02564% with 69 lines in your changes missing coverage. Please review.

Project coverage is 41.41%. Comparing base (ec84ae1) to head (68f26b9).
Report is 4 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...onfignode/procedure/PartitionTableAutoCleaner.java 20.00% 20 Missing ⚠️
.../org/apache/iotdb/commons/schema/ttl/TTLCache.java 0.00% 14 Missing ⚠️
...onfignode/persistence/partition/PartitionInfo.java 0.00% 8 Missing ⚠️
...t/write/partition/AutoCleanPartitionTablePlan.java 84.37% 5 Missing ⚠️
...apache/iotdb/commons/utils/TimePartitionUtils.java 16.66% 5 Missing ⚠️
.../iotdb/commons/partition/SeriesPartitionTable.java 20.00% 4 Missing ⚠️
...g/apache/iotdb/confignode/persistence/TTLInfo.java 0.00% 3 Missing ⚠️
...he/iotdb/commons/partition/DataPartitionTable.java 0.00% 3 Missing ⚠️
...che/iotdb/confignode/manager/ProcedureManager.java 33.33% 2 Missing ⚠️
.../persistence/partition/DatabasePartitionTable.java 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             dev/1.3   #14759      +/-   ##
=============================================
- Coverage      41.42%   41.41%   -0.02%     
  Complexity       193      193              
=============================================
  Files           3529     3531       +2     
  Lines         225872   225980     +108     
  Branches       26875    26887      +12     
=============================================
+ Hits           93571    93583      +12     
- Misses        132301   132397      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 632026c into dev/1.3 Jan 23, 2025
25 of 27 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the cp-auto-clean-partition-table branch January 23, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CRZbulabula @OneSizeFitsQuorum